Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic that changes connection to a writer #427

Merged
merged 1 commit into from
May 3, 2023

Conversation

sergiyvamz
Copy link
Contributor

Summary

Remove logic that changes connection to a writer when setReadOnly(false) is called on reader connection.
#426

Additional Reviewers

@karenc-bq
@aaron-congo

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@congoamz congoamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but there is a qodana warning about accessing explicitlyReadOnly in synchronized and non-synchronized contexts that we might want to look into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants