Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdk diff "expand" #1629

Open
eladb opened this issue Jan 29, 2019 · 1 comment
Open

cdk diff "expand" #1629

eladb opened this issue Jan 29, 2019 · 1 comment
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@eladb
Copy link
Contributor

eladb commented Jan 29, 2019

Currently cdk diff will show full diff only for changed values. We should improve this to allow:

  1. Not showing full diffs even for changed values
  2. Showing full content for new values as well

Proposed API:

cdk diff --no-expand # show only a list of changed resources
cdk diff --expand=update
cdk diff --expand=new
cdk diff --expand=old
cdk diff --expand=all

I wonder if we should also allow people to opt out of emitting the IAM policy table in diffs (--no-security-diff). Perhaps --mini should imply --no-security-diff and --no-expand?

@eladb eladb added feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI labels Jan 29, 2019
@shivlaks shivlaks added the effort/large Large work item – several weeks of effort label Feb 6, 2020
@shivlaks shivlaks added the p2 label Aug 7, 2020
@NGL321 NGL321 assigned rix0rrr and unassigned shivlaks Jan 25, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@hlascelles
Copy link

We would like this. Probably related: #679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/large Large work item – several weeks of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

4 participants