feat(ssm): add ability to specify SSM Parameter tier #6326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
robertd
force-pushed
the
rdjurasaj/add-tiers-to-ssm-parameters
branch
from
51764bb to
036e173
Compare
robertd
changed the title
|
Rebased and updated commit messages. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
previously requested changes
Feb 18, 2020
|
Sorry, I missed your comment about PR splitting. I’ll do that later today
for sure.
…On Tue, Feb 18, 2020 at 11:52 AM Mitchell Valine ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We should separate out the "chore" and "feat" PRs. The changelog is
auto-generated based on commit titles and these 2 commits will be squashed
together under our normal process.
------------------------------
In ***@***.***/aws-ssm/lib/parameter.ts
<#6326 (comment)>:
> const resource = new ssm.CfnParameter(this, 'Resource', {
allowedPattern: props.allowedPattern,
description: props.description,
name: this.physicalName,
+ tier: props.tier || undefined,
since props.tier is possibly undefined, isn't props.tier || undefined
equivalent to props.tier ?
------------------------------
In ***@***.***/aws-ssm/lib/parameter.ts
<#6326 (comment)>:
> const resource = new ssm.CfnParameter(this, 'Resource', {
allowedPattern: props.allowedPattern,
description: props.description,
name: this.physicalName,
+ tier: props.tier || undefined,
same as above, props.tier should suffice.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6326?email_source=notifications&email_token=AAAHWN72TUFAN4WBHLPAXW3RDQ377A5CNFSM4KW666L2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV7LCDI#pullrequestreview-360624397>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHWN3HNMVNMFFMYPLLQZTRDQ377ANCNFSM4KW666LQ>
.
|
robertd
force-pushed
the
rdjurasaj/add-tiers-to-ssm-parameters
branch
from
036e173 to
074130a
Compare
mergify
bot
dismissed
MrArnoldPalmer’s stale review
Pull request has been modified.
|
@MrArnoldPalmer |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
MrArnoldPalmer
approved these changes
Feb 19, 2020
|
Thank you for contributing! Your pull request is now being automatically merged. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two separate PRs here:
feat(aws-ssm): add ability to specify SSM Parameter tierThis PR allows to specify SSM Parameter tier
Advanced | Intelligent-Tiering | Standardas specified in the docs.chore(aws-ssm): add checks for parameter name and description lengthAdded checks for SSM Parameter description and name length.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license