Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@aws-sdk/types is a production dependency, but is full of empty JS files #1649

Closed
mhart opened this issue Oct 30, 2020 · 4 comments
Closed
Assignees

Comments

@mhart
Copy link
Contributor

mhart commented Oct 30, 2020

Describe the bug

@aws-sdk/types is a production dependency of many modules in this project, but it is only made up of empty *.js files and has no use at runtime.

I believe it's only intended to provide type information – so a) there should be no *.js files and b) it should be in devDependencies instead of dependencies

This is something that should be fixed before GA so that ppl don't somehow rely on it being available without them installing it as a dev dep themselves (and also to save 500kb of production deps)

@alexforsyth
Copy link
Contributor

@mhart Thanks for opening this. We're taking a look and we'll fix this soon

@mhart
Copy link
Contributor Author

mhart commented Nov 2, 2020

Glad to hear it, thanks @alexforsyth!

@alexforsyth
Copy link
Contributor

This will be going out with the next release

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants