Typescript 3.7.x breaking @aws-sdk/types

[alexforsyth]

Describe the bug
@aws-sdk/types declares UserAgentPair.

export declare type UserAgentPair = [name: string, version?: string];

Pairs are not supported in Typescript 3.7.x
https://devblogs.microsoft.com/typescript/announcing-typescript-4-0/#labeled-tuple-elements.

Users running typescript < 4.0.0 cannot correctly get types.

SDK version number
3.3.0

Is the issue in the browser/Node.js/ReactNative?
All

Details of the browser/Node.js/ReactNative version
node v14.15.4

To Reproduce (observed behavior)

The following error is thrown for the code example give below:

$ yarn build
yarn run v1.22.5
$ tsc
node_modules/@aws-sdk/types/dist/cjs/util.d.ts:92:42 - error TS1005: ',' expected.

92 export declare type UserAgentPair = [name: string, version?: string];
                                            ~

node_modules/@aws-sdk/types/dist/cjs/util.d.ts:92:60 - error TS1005: ',' expected.

92 export declare type UserAgentPair = [name: string, version?: string];
                                                              ~


Found 2 errors.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

package.json

{
  "name": "test-ts-3.7",
  "version": "1.0.0",
  "main": "index.js",
  "license": "MIT",
  "scripts": {
    "build": "tsc"
  },
  "dependencies": {
    "@aws-sdk/client-s3": "3.3.0"
  },
  "devDependencies": {
    "@types/node": "14.14.22",
    "typescript": "3.7.5"
  }
}

index.ts

import { S3 } from "@aws-sdk/client-s3";

(async () => {
  const region = "us-west-2";
  const client = new S3({ region });
  await client.listBuckets({});
})();

tsconfig.json

{
  "compilerOptions": {
    "target": "es5",
    "module": "commonjs",
    "strict": true,
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true
  }
}

Expected behavior
No error is thrown when compiling client code with TypeScript version 3.7.x

[trivikr]

This issue would be fixed by using downlevel-dts to create type definition files which support TS 3.4 or later.

[trivikr]

Three PRs which need to be merged before TS 3.4 compatible types can be generated:

• chore(protocol_clients): update generated tests #1936
• fix(generate-clients): call mergeManifest when constructor.name is Object #1937
• chore(packages): use types as a declarationDir #1938

Experimental commits are in downlevel-dts branch https://github.com/trivikr/aws-sdk-js-v3/tree/downlevel-dts

[ohana54]

@trivikr I upgraded to 3.4.0 and it still doesn't work - I use TS 3.9.7, while labeled tuples were added in 4.x. It's probably due to this condition:

aws-sdk-js-v3/packages/types/package.json

Line 29 in 63ad215

"<3.9": {

If I change it to <= it works fine.

[trivikr]

I upgraded to 3.4.0 and it still doesn't work - I use TS 3.9.7, while labeled tuples were added in 4.x. It's probably due to this condition:

I'll create a separate issue specific to 3.9.7 for tracking.
I'll also update downlevel-dts README https://github.com/sandersn/downlevel-dts#usage

[ohana54]

Thanks! I can open a PR for the readme.
EDIT: sandersn/downlevel-dts#51

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.