-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support default role assumers #2221
feat: support default role assumers #2221
Conversation
5f99930
to
0eae9ac
Compare
...pt-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddAwsAuthPlugin.java
Outdated
Show resolved
Hide resolved
0eae9ac
to
db67264
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit.
Co-authored-by: Trivikram Kamat <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Resolves #2087
Resolves #1998
Resolves #2011
Resolves #1193
Replaces #2179
Description
This change provides default role assumer for the default credentials provider that calls
sts:assumeRole
orsts:assumeRoleWithWebIdentity
under the hood. As a result, users don't need to import STS client and supply their own role assumer(like mentioned in #1193).These assumer is exported from STS client not the
packages/
folder because it can avoid circular dependency. Thecredential-provider-*
packages having any dependency over STS client will cause the same issue. As a result this change makes the source code comply the contract thatclients/
depends onpackages/
;lib/
depends onpackages/
andclients/
.Testing
✅ It has been manually tested with credential files containing assume role chaining
✅ It has been validate with bundler(Webpack) that tree shaking work well
Additional context
This PR is based #2179 but it doen't use dynamic import, and doen't introduce separate STS clients.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.