Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mixin to help convert blobs to string #4265

Closed
1 task done
kuhe opened this issue Dec 8, 2022 · 5 comments
Closed
1 task done

Add mixin to help convert blobs to string #4265

kuhe opened this issue Dec 8, 2022 · 5 comments
Assignees
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@kuhe
Copy link
Contributor

kuhe commented Dec 8, 2022

Describe the feature

#2252

There is a widely supported request for a convenient way to convert a lambda invocation response (blob) to string.
This can be done with some user code, but we can also apply an official mixin method to make it easier for users.

Use Case

lambda invocation response payload

Proposed Solution

apply a mixin similar to the one used for Streaming collectors in https://github.com/aws/aws-sdk-js-v3/tree/main#streams

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request

SDK version used

3.222.0

Environment details (OS name and version, etc.)

all

@kuhe kuhe added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2022
@kuhe kuhe self-assigned this Dec 8, 2022
@ajredniwja ajredniwja added p1 This is a high priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Dec 8, 2022
@RanVaknin
Copy link
Contributor

related: #2123

@kuhe
Copy link
Contributor Author

kuhe commented Jun 15, 2023

work on this will include the issue described in #4786

PR #4836 address payload blobs automatic string conversion

Some blobs are not payloads and should be addressed separately. For non-payload blobs, the solution should involve expanding the toUtf8 and therefore the interface Encoder from smithy types from (Uint8Array => string) to (string | Uint8Array => string). However, that is a breaking change and will require some design consideration.

@kuhe
Copy link
Contributor Author

kuhe commented Jun 22, 2023

@kuhe kuhe added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed p1 This is a high priority issue labels Jun 27, 2023
@kuhe
Copy link
Contributor Author

kuhe commented Sep 8, 2023

#5181

@kuhe kuhe closed this as completed Feb 23, 2024
Copy link

github-actions bot commented Mar 9, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

No branches or pull requests

4 participants