Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use updated dist glob pattern in package.json #4628

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 10, 2023

Issue

Refs: smithy-lang/smithy-typescript#731

Description

Use updated dist glob pattern in package.json

Testing

Verified that dist-* folders are added in on run pack command with npm@9

$ pwd
/local/home/trivikr/workspace/aws-sdk-js-v3/packages/types

$ yarn build
...
Done in 5.91s.

$ npm --version
9.6.4

$ npm pack
npm notice 
npm notice 📦  @aws-sdk/[email protected]
npm notice === Tarball Contents === 
npm notice 11.4kB LICENSE                                       
npm notice 252B   README.md                                     
npm notice 77B    dist-cjs/abort.js                             
npm notice 333B   dist-cjs/auth.js                              
npm notice 77B    dist-cjs/checksum.js                          
npm notice 77B    dist-cjs/client.js                            
npm notice 77B    dist-cjs/command.js                           
npm notice 77B    dist-cjs/connection/config.js                 
npm notice 266B   dist-cjs/connection/index.js                  
npm notice 77B    dist-cjs/connection/manager.js                
npm notice 77B    dist-cjs/connection/pool.js                   
npm notice 77B    dist-cjs/credentials.js                       
npm notice 77B    dist-cjs/crypto.js                            
npm notice 313B   dist-cjs/dns.js                               
npm notice 337B   dist-cjs/endpoint.js                          
npm notice 77B    dist-cjs/eventStream.js                       
npm notice 77B    dist-cjs/http.js                              
npm notice 77B    dist-cjs/identity/AnonymousIdentity.js        
npm notice 77B    dist-cjs/identity/AwsCredentialIdentity.js    
npm notice 77B    dist-cjs/identity/Identity.js                 
npm notice 413B   dist-cjs/identity/index.js                    
npm notice 77B    dist-cjs/identity/LoginIdentity.js            
npm notice 77B    dist-cjs/identity/TokenIdentity.js            
npm notice 1.6kB  dist-cjs/index.js                             
npm notice 77B    dist-cjs/logger.js                            
npm notice 77B    dist-cjs/middleware.js                        
npm notice 77B    dist-cjs/pagination.js                        
npm notice 77B    dist-cjs/profile.js                           
npm notice 77B    dist-cjs/request.js                           
npm notice 77B    dist-cjs/response.js                          
npm notice 77B    dist-cjs/retry.js                             
npm notice 77B    dist-cjs/serde.js                             
npm notice 77B    dist-cjs/shapes.js                            
npm notice 77B    dist-cjs/signature.js                         
npm notice 77B    dist-cjs/stream.js                            
npm notice 77B    dist-cjs/token.js                             
npm notice 442B   dist-cjs/transfer.js                          
npm notice 77B    dist-cjs/util.js                              
npm notice 77B    dist-cjs/waiter.js                            
npm notice 11B    dist-es/abort.js                              
npm notice 193B   dist-es/auth.js                               
npm notice 11B    dist-es/checksum.js                           
npm notice 11B    dist-es/client.js                             
npm notice 11B    dist-es/command.js                            
npm notice 11B    dist-es/connection/config.js                  
npm notice 77B    dist-es/connection/index.js                   
npm notice 11B    dist-es/connection/manager.js                 
npm notice 11B    dist-es/connection/pool.js                    
npm notice 11B    dist-es/credentials.js                        
npm notice 11B    dist-es/crypto.js                             
npm notice 175B   dist-es/dns.js                                
npm notice 195B   dist-es/endpoint.js                           
npm notice 11B    dist-es/eventStream.js                        
npm notice 11B    dist-es/http.js                               
npm notice 11B    dist-es/identity/AnonymousIdentity.js         
npm notice 11B    dist-es/identity/AwsCredentialIdentity.js     
npm notice 11B    dist-es/identity/Identity.js                  
npm notice 172B   dist-es/identity/index.js                     
npm notice 11B    dist-es/identity/LoginIdentity.js             
npm notice 11B    dist-es/identity/TokenIdentity.js             
npm notice 753B   dist-es/index.js                              
npm notice 11B    dist-es/logger.js                             
npm notice 11B    dist-es/middleware.js                         
npm notice 11B    dist-es/pagination.js                         
npm notice 11B    dist-es/profile.js                            
npm notice 11B    dist-es/request.js                            
npm notice 11B    dist-es/response.js                           
npm notice 11B    dist-es/retry.js                              
npm notice 11B    dist-es/serde.js                              
npm notice 11B    dist-es/shapes.js                             
npm notice 11B    dist-es/signature.js                          
npm notice 11B    dist-es/stream.js                             
npm notice 11B    dist-es/token.js                              
npm notice 290B   dist-es/transfer.js                           
npm notice 11B    dist-es/util.js                               
npm notice 11B    dist-es/waiter.js                             
npm notice 1.5kB  dist-types/abort.d.ts                         
npm notice 1.3kB  dist-types/auth.d.ts                          
npm notice 2.1kB  dist-types/checksum.d.ts                      
npm notice 1.6kB  dist-types/client.d.ts                        
npm notice 561B   dist-types/command.d.ts                       
npm notice 226B   dist-types/connection/config.d.ts             
npm notice 77B    dist-types/connection/index.d.ts              
npm notice 924B   dist-types/connection/manager.d.ts            
npm notice 674B   dist-types/connection/pool.d.ts               
npm notice 425B   dist-types/credentials.d.ts                   
npm notice 1.9kB  dist-types/crypto.d.ts                        
npm notice 2.6kB  dist-types/dns.d.ts                           
npm notice 1.6kB  dist-types/endpoint.d.ts                      
npm notice 3.6kB  dist-types/eventStream.d.ts                   
npm notice 3.4kB  dist-types/http.d.ts                          
npm notice 114B   dist-types/identity/AnonymousIdentity.d.ts    
npm notice 566B   dist-types/identity/AwsCredentialIdentity.d.ts
npm notice 326B   dist-types/identity/Identity.d.ts             
npm notice 172B   dist-types/identity/index.d.ts                
npm notice 360B   dist-types/identity/LoginIdentity.d.ts        
npm notice 292B   dist-types/identity/TokenIdentity.d.ts        
npm notice 753B   dist-types/index.d.ts                         
npm notice 907B   dist-types/logger.d.ts                        
npm notice 17.3kB dist-types/middleware.d.ts                    
npm notice 743B   dist-types/pagination.d.ts                    
npm notice 395B   dist-types/profile.d.ts                       
npm notice 88B    dist-types/request.d.ts                       
npm notice 1.1kB  dist-types/response.d.ts                      
npm notice 4.1kB  dist-types/retry.d.ts                         
npm notice 3.5kB  dist-types/serde.d.ts                         
npm notice 2.3kB  dist-types/shapes.d.ts                        
npm notice 4.0kB  dist-types/signature.d.ts                     
npm notice 768B   dist-types/stream.d.ts                        
npm notice 370B   dist-types/token.d.ts                         
npm notice 880B   dist-types/transfer.d.ts                      
npm notice 4.4kB  dist-types/util.d.ts                          
npm notice 1.2kB  dist-types/waiter.d.ts                        
npm notice 1.5kB  package.json                                  
npm notice === Tarball Details === 
npm notice name:          @aws-sdk/types                          
npm notice version:       3.306.0                                 
npm notice filename:      aws-sdk-types-3.306.0.tgz               
npm notice package size:  25.4 kB                                 
npm notice unpacked size: 88.2 kB                                 
npm notice shasum:        44c83a1f7cc7f850c3652a6e0ebba64e58d290fa
npm notice integrity:     sha512-jMe7yLpXYTWLv[...]8OuhNTJ9Viuxg==
npm notice total files:   114                                     
npm notice 
aws-sdk-types-3.306.0.tgz

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested review from a team as code owners April 10, 2023 14:39
@trivikr trivikr merged commit 352393d into aws:main Apr 10, 2023
@trivikr trivikr deleted the dist-glob branch April 10, 2023 15:29
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants