Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use bundled dist-cjs build #5687

Merged
merged 9 commits into from
Jan 18, 2024
Merged

feat: use bundled dist-cjs build #5687

merged 9 commits into from
Jan 18, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jan 17, 2024

Issue

paired with smithy-lang/smithy-typescript#1146

Description

Creates a bundled "inline" dist-cjs artifact. Existing files are stubbed as re-exports of this index. Files with "variants" i.e. react-native metadata are excluded from the bundle to maintain the ability to bundle alternate implementations.

Testing

  • yarn test:integration
  • yarn test:e2e
  • yarn test:e2e:legacy
  • manual testing with react-native metro bundler

@kuhe kuhe requested review from a team as code owners January 17, 2024 21:52
@kuhe kuhe merged commit 5f79e22 into aws:main Jan 18, 2024
2 of 3 checks passed
@kuhe kuhe deleted the feat/dist-cjs branch January 18, 2024 00:01
Copy link

github-actions bot commented Feb 1, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants