Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to authAddConnection metrics #4943

Merged
merged 6 commits into from
Oct 9, 2024

Conversation

manodnyab
Copy link
Contributor

@manodnyab manodnyab commented Oct 4, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Remove auth_addConnection from telemetryOverride and get the definition from common

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab marked this pull request as ready for review October 8, 2024 20:50
@manodnyab manodnyab requested review from a team as code owners October 8, 2024 20:50
Copy link

github-actions bot commented Oct 8, 2024

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@manodnyab manodnyab enabled auto-merge (squash) October 9, 2024 22:57
@manodnyab manodnyab merged commit a74994d into main Oct 9, 2024
12 of 16 checks passed
@manodnyab manodnyab deleted the manodnyb/addSourceToMetrics branch October 9, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants