fix(amazonq): Fix bug for @workspace cannot properly locate certain folders for certain project setup
#4975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
changed the title
@workspace cannot properly locate certain folders for certain project setup
rli
reviewed
Oct 16, 2024
.changes/next-release/bugfix-9e318f1e-baa7-4d10-98de-edfa70fcd7e0.json
Outdated
Show resolved
Hide resolved
rli
reviewed
Oct 16, 2024
...oftware/aws/toolkits/jetbrains/services/cwc/editor/context/project/ProjectContextProvider.kt
Outdated
Show resolved
Hide resolved
…7e0.json Co-authored-by: Richard Li <[email protected]>
…ns into multi_folder
Will-ShaoHua
approved these changes
Oct 17, 2024
rli
approved these changes
Oct 17, 2024
rli
reviewed
Oct 17, 2024
| @@ -275,7 +275,7 @@ class ProjectContextProvider(val project: Project, private val encoderServer: En | |||
| var currentTotalFileSize = 0L | |||
| val featureDevSessionContext = FeatureDevSessionContext(project) | |||
| val allFiles = mutableListOf<VirtualFile>() | |||
| project.guessProjectDir()?.let { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When the project root is removed as the module but src folders are promoted to the modules level, the
@workspaceindexing cannot properly resolve the project root folder, causing indexing to only apply to a subset of the workspace.The
guessProjectDirfunction does not work as expected, it resolves to one of the src folders. We should use basePath or equavalent.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.