Draft: File level acceptance #5044
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -16,6 +16,8 @@ | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendCodeResult | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendSystemPrompt | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateChatAnswer | |||
Check warning
Code scanning / QDJVMC
Unused import directive Warning
| @@ -16,6 +16,8 @@ | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendCodeResult | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendSystemPrompt | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.sendUpdatePlaceholder | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateChatAnswer | |||
| import software.aws.toolkits.jetbrains.services.amazonqFeatureDev.messages.updateFileComponent | |||
Check warning
Code scanning / QDJVMC
Unused import directive Warning
| @@ -88,7 +90,7 @@ | |||
| } | |||
|
|
|||
| // Atm this is the only possible path as codegen is mocked to return empty. | |||
| if (filePaths.size or deletedFiles.size == 0) { | |||
| if (filePaths.size == 0 && deletedFiles.size == 0) { | |||
Check notice
Code scanning / QDJVMC
Size zero check can be replaced with 'isEmpty()' Note
| @@ -88,7 +90,7 @@ | |||
| } | |||
|
|
|||
| // Atm this is the only possible path as codegen is mocked to return empty. | |||
| if (filePaths.size or deletedFiles.size == 0) { | |||
| if (filePaths.size == 0 && deletedFiles.size == 0) { | |||
Check notice
Code scanning / QDJVMC
Size zero check can be replaced with 'isEmpty()' Note
| filePaths = filePaths, | ||
| deletedFiles = deletedFiles, | ||
| messageId = messageId, | ||
| suspend fun MessagePublisher.updateChatAnswer(tabId: String, messageId: String, message: String?, followUps: List<FollowUp>) { |
Check warning
Code scanning / QDJVMC
Redundant 'suspend' modifier Warning
| filePaths = filePaths, | ||
| deletedFiles = deletedFiles, | ||
| messageId = messageId, | ||
| suspend fun MessagePublisher.updateChatAnswer(tabId: String, messageId: String, message: String?, followUps: List<FollowUp>) { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.