Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amazonq): fix inline chat can be invoked in non-editor windows #5076

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Nov 11, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

only allow invoking inline chat if it's from regular file editor

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zixlin7 zixlin7 requested review from a team as code owners November 11, 2024 20:26
@zixlin7
Copy link
Contributor Author

zixlin7 commented Nov 11, 2024

/retryBuilds

@zixlin7 zixlin7 requested a review from rli November 12, 2024 16:02
@rli rli merged commit 2032a57 into aws:main Nov 12, 2024
10 of 13 checks passed
@zixlin7 zixlin7 deleted the fixConsole branch November 12, 2024 22:13
zixlin7 added a commit to zixlin7/aws-toolkit-jetbrains that referenced this pull request Nov 13, 2024
@zixlin7 zixlin7 mentioned this pull request Nov 13, 2024
6 tasks
zixlin7 added a commit to zixlin7/aws-toolkit-jetbrains that referenced this pull request Nov 13, 2024
zixlin7 added a commit to zixlin7/aws-toolkit-jetbrains that referenced this pull request Nov 13, 2024
zixlin7 added a commit that referenced this pull request Nov 13, 2024
* patch for #5076

* Update plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/OpenChatInputAction.kt

Co-authored-by: Richard Li <[email protected]>

---------

Co-authored-by: Richard Li <[email protected]>
dhasani23 pushed a commit to ntarakad-aws/aws-toolkit-jetbrains that referenced this pull request Nov 18, 2024
…ws#5076)

Only allow invoking inline chat if it's from regular file editor
dhasani23 pushed a commit to ntarakad-aws/aws-toolkit-jetbrains that referenced this pull request Nov 18, 2024
* patch for aws#5076

* Update plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/OpenChatInputAction.kt

Co-authored-by: Richard Li <[email protected]>

---------

Co-authored-by: Richard Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants