Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patching sqlalchemy #124

Closed
zhammer opened this issue Jan 24, 2019 · 3 comments
Closed

Patching sqlalchemy #124

zhammer opened this issue Jan 24, 2019 · 3 comments

Comments

@zhammer
Copy link

zhammer commented Jan 24, 2019

Is there a reason we can't just patch out the sqlalchemy SessionMaker with the XRaySessionMaker?

Curious why this is isolated from the rest of the patching.

@chanchiem
Copy link
Contributor

Hey Zhammer,

SQLAlchemy was written through the following pull request: #14

And although it looks like it could've been written with the patcher, the current implementation utilized a different design specific to SQLAlchemy's base session and query classes.

@zhammer
Copy link
Author

zhammer commented Jan 28, 2019

I'm using postgres and actually just patched out psycopg2 which has worked fine for me!

@chanchiem
Copy link
Contributor

Closing since you've found a solution to your underlying problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants