Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support MariaDB JDBC Connector #341

Closed
1 of 2 tasks
davecramer opened this issue Feb 9, 2023 · 2 comments
Closed
1 of 2 tasks

feat: Support MariaDB JDBC Connector #341

davecramer opened this issue Feb 9, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@davecramer
Copy link
Contributor

davecramer commented Feb 9, 2023

Describe the feature

Currently jdbc scheme's are hard coded to postgres and mysql. Remove hard coded schemes in favour of a dialect

Use Case

no support for mariadb

Proposed Solution

use a dialect to figure out which one to load

Other Information

#342

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

The AWS Advanced JDBC Driver version used

Latest

JDK version used

1.8

Operating System and version

any

@davecramer davecramer added the enhancement New feature or request label Feb 9, 2023
@karenc-bq
Copy link
Contributor

karenc-bq commented Feb 9, 2023

Thank you for logging this enhancement @davecramer.

Could we clarify the request? The failover plugin is only applicable for Aurora. Since Aurora is not available for the MariaDB engine, the wrapper’s hard coded JDBC Schemes only apply to failover plugin functionality. Would rebranding this ticket as "A dialect implementation to remove hardcoded JDBC schemes" be more along the lines of this proposed enhancement?

For context, the Wrapper is compatible with the MariaDB Connector/J driver against Aurora MySQL and we're working through testing verification before we claim official support.

@hsuamz hsuamz changed the title support mariadb jdbc connector feat: Support MariaDB JDBC Connector Feb 13, 2023
@karenc-bq
Copy link
Contributor

Dialect changes merged in PR #372, closing this ticket now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants