Use default connection check intervals/timeouts in the EFM plugin #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aaron-congo
commented
Nov 22, 2022
•
aaron-congo
commented
- previously, the interval/timeout values could be set to 0 or Long.MAX_VALUE. This PR changes these values to specified defaults when a user-supplied setting is not available
- also changed various EFM variables to thread-safe variants. These variables are shared between the main thread and the monitor thread
aaron-congo
changed the title
sergiyvamz
approved these changes
Dec 20, 2022
|
So I'm looking at the title of this and trying to determine how it could be set to MAX_VALUE ? |
There were a couple spots where this.connectionCheckInvervalMillis was being set to the return value of findShortestIntervalMillis in the MonitorImpl file. The original implementation of this function returned MAX_VALUE if there were no contexts in the MonitorImpl class. The fix for this specific problem is in the MonitorImpl changes in this PR |
sergiyvamz
approved these changes
Jan 5, 2023
karenc-bq
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.