Lock initialization of AuroraHostListProvider #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecramer
approved these changes
Feb 16, 2023
davecramer
reviewed
Feb 21, 2023
| @@ -207,6 +215,7 @@ protected void init() throws SQLException { | |||
| } | |||
|
|
|||
| this.isInitialized = true; | |||
| lock.unlock(); | |||
There was a problem hiding this comment.
It might make sense to create a utility lock that implements Closable and then wrap this in try block, either way it should be in a try block with the unlock in a finally
sergiyvamz
reviewed
Feb 22, 2023
| : clusterRdsHostUrl; | ||
| this.isPrimaryClusterId = true; | ||
| try { | ||
| lock.lock(); |
There was a problem hiding this comment.
Lock should be out of tr-finally block. We don't need to unlock if lock fails.
sergiyvamz
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #343
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.