Remove isMultiWriterCluster flag and ignore stale records when querying the topology #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crystall-bitquill
force-pushed
the
remove-isMultiWriterCluster
branch
from
e665038
to
07edfe2
Compare
sergiyvamz
reviewed
May 10, 2023
| @@ -39,6 +42,8 @@ public class HostSpec { | |||
| protected Set<String> allAliases = ConcurrentHashMap.newKeySet(); | |||
| protected long weight; // Greater or equal 0. Lesser the weight, the healthier node. | |||
| protected String hostId; | |||
| protected String lastUpdateTime; | |||
There was a problem hiding this comment.
Can we use date/timestamp object instead of String?
sergiyvamz
approved these changes
May 10, 2023
…hen querying the topology
crystall-bitquill
force-pushed
the
remove-isMultiWriterCluster
branch
from
cde2c57
to
ae5d987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the isMultiWriterCluster flag from the AuroraTopologyService and add checks for stale topology records.
Description
Multi writer clusters are not longer supported, so the isMultiWriterCluster flag that was used to disable failover has been removed. Additionally, checks have been added to ensure stale writer records that are obtained post writer-failover are not being used.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.