chore: China endpoints #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonli-improving
force-pushed
the
china-endpoints
branch
from
fc8b982
to
1490c3d
Compare
karenc-bq
reviewed
Jan 17, 2024
karenc-bq
reviewed
Jan 17, 2024
karenc-bq
reviewed
Jan 19, 2024
wrapper/src/test/java/software/amazon/jdbc/util/RdsUtilsTests.java
Outdated
Show resolved
Hide resolved
karenc-bq
approved these changes
Jan 20, 2024
|
The fix for the failing integration tests is on |
This reverts commit f5c41e9.
jasonli-improving
force-pushed
the
china-endpoints
branch
from
f94e32a
to
3b891f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update China endpoint regex
Description
Changed China endpoint regex to support both
...<region>.rds.amazonaws.com.cnand...rds.<region>.amazonaws.com.cnpatterns. Also changed Aurora pattern due to issue with .cn being cut off when matched.Updated unit tests for testing both Chinese patterns.
Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.