feat: update HostSelector implementations to account for HostAvailablity #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
approved these changes
Jan 29, 2024
brunos-bq
approved these changes
Jan 29, 2024
| @@ -42,7 +43,8 @@ public HostSpec getHost( | |||
| @NonNull final HostRole role, | |||
| @Nullable final Properties props) throws SQLException { | |||
| final List<HostSpec> eligibleHosts = hosts.stream() | |||
| .filter(hostSpec -> role.equals(hostSpec.getRole())) | |||
| .filter(hostSpec -> | |||
There was a problem hiding this comment.
NIT: add a comment above this level explaining the filter clause
aaronchung-bitquill
force-pushed
the
feature/host-selector-availability
branch
4 times, most recently
from
8a4390d
to
c8f85c9
Compare
aaronchung-bitquill
force-pushed
the
feature/host-selector-availability
branch
from
c8f85c9
to
94fc121
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: update HostSelector implementations to account for HostAvailablity
Description
For each implementation of HostSelector, it filters and creates a list of eligible hosts. Added an extra condition to only filter out ones that are
HostAvailability.NOT_AVAILABLEAdditional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.