feat: HostSpec to not default lastUpdateTime. Handle null lastUpdateTime in RdsHostListProvider #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchung-bitquill
force-pushed
the
feature/remove-default-host-last-update-time
branch
from
06da9df
to
5280d61
Compare
sergiyvamz
approved these changes
Feb 8, 2024
…ime in RdsHostListProvider
aaronchung-bitquill
force-pushed
the
feature/remove-default-host-last-update-time
branch
from
5280d61
to
aeace9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
feat: HostSpec to not default lastUpdateTime. Handle null lastUpdateTime in RdsHostListProvider
Description
No more defaultLastUpdateTime in the HostSpecBuilder (previously it would default if lastUpdateTime was
null).In the
RdsHostListProvider#processQueryResultswhere it sorts writer hosts based onlastUpdateTime, it handles nulllastUpdateTimevalues by sorting/deprioritizing them to last.Additional Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.