Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutationQueueExecutionTimeout() doesn't work #105

Closed
SStesh opened this issue Jan 23, 2019 · 2 comments
Closed

mutationQueueExecutionTimeout() doesn't work #105

SStesh opened this issue Jan 23, 2019 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@SStesh
Copy link

SStesh commented Jan 23, 2019

Describe the bug
There is a method mutationQueueExecutionTimeout() added in SDK version 2.7.4. But it really doesn't change timeout value and default value is remaining.

This is a source code of mutationQueueExecutionTimeout method at SDK (AWSAppSyncClient.java):

public Builder mutationQueueExecutionTimeout(long mutationQueueExecutionTimeout) {
    mutationQueueExecutionTimeout = mutationQueueExecutionTimeout;
    return this;
}

But it doesn't change a class member and changes argument instead. It must modify mMutationQueueExecutionTimeout defined at Builder class as:
long mMutationQueueExecutionTimeout = 5 * 60 * 1000;

Environment(please complete the following information):

  • AppSync SDK Version: 2.7.5
@scb01 scb01 self-assigned this Jan 23, 2019
@scb01 scb01 added AppSync bug Something isn't working labels Jan 23, 2019
@scb01
Copy link
Contributor

scb01 commented Jan 23, 2019

@SStesh
You are a 100% correct. Thank you for bringing this to my attention. The fix for this issue will be available in the next version of the SDK. I will post back here once the release is out.

@scb01
Copy link
Contributor

scb01 commented Jan 24, 2019

@SStesh

Closing the loop on this issue - the fix is included in v2.7.6 of the SDK.

@scb01 scb01 closed this as completed Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants