Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when subscription is cancelled #111

Closed
mitmak777 opened this issue Feb 4, 2019 · 4 comments
Closed

Memory leak when subscription is cancelled #111

mitmak777 opened this issue Feb 4, 2019 · 4 comments
Assignees
@scb01 @rohandubal
Labels
bug Something isn't working closing-soon pending-response Issue is pending response from the issue requestor

Comments

@mitmak777
Copy link

Describe the bug
subscriptionsById still holds the subscription instance after it is cancelled and unsubscribed.

I believe the cause is this line

aws-mobile-appsync-sdk-android/aws-android-sdk-appsync/src/main/java/com/amazonaws/mobileconnectors/appsync/subscription/RealSubscriptionManager.java

Line 106 in 55717d1

subscriptionsById.remove(subscriptionObject);

It try to remove the instance by key but the value is passed to the remove function
@sunchunqiang sunchunqiang assigned scb01 and rohandubal and unassigned scb01 Feb 4, 2019
@sunchunqiang sunchunqiang added the investigating This issue is being investigated label Feb 4, 2019
@scb01 scb01 self-assigned this Feb 5, 2019
@scb01
Copy link
Contributor

scb01 commented Feb 5, 2019

@mitmak777
Nice catch! Thank you. This will be fixed in one of our upcoming releases. We will post back on this thread once the release is out.

@scb01 scb01 added bug Something isn't working and removed investigating This issue is being investigated labels Feb 5, 2019
@scb01 scb01 mentioned this issue Feb 5, 2019
Merged
@rohandubal rohandubal added the pending-release Code has been merged but pending release label Feb 6, 2019
@mitmak777
Copy link
Author

Thanks for the quick response.

@scb01
Copy link
Contributor

scb01 commented Feb 13, 2019

@mitmak777

The latest version of the sdk (v2.7.7) contains the fix. Please upgrade and let us know how it goes.

@scb01 scb01 added pending-response Issue is pending response from the issue requestor and removed pending-release Code has been merged but pending release labels Feb 13, 2019
@scb01
Copy link
Contributor

scb01 commented Feb 26, 2019

@mitmak777
Closing this issue as you may be all set. Please feel free to post here if this issue is still happening .

@scb01 scb01 closed this as completed Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scb01 scb01

@rohandubal rohandubal

Labels
bug Something isn't working closing-soon pending-response Issue is pending response from the issue requestor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mitmak777 @scb01 @rohandubal @frankmuellr @sunchunqiang