AppSyncCustomNetworkInvoker JSON parse error when data is null due to mutation validation errors on server

[pthomascelltrak]

Referenced line assumes that there will always be a data object returned for a mutation. This is not true when validation fails - only the errors field is set. This should probably use optJSONObject.

aws-mobile-appsync-sdk-android/aws-android-sdk-appsync/src/main/java/com/amazonaws/mobileconnectors/appsync/AppSyncCustomNetworkInvoker.java

Line 243 in 8cf6844

jsonObject.getJSONObject("data"),

[doc-rj-celltrak]

This bug prevents us from learning that an offline mutation eventually fails, unlike iOS. It's only a one-line fix. I hope you can prioritize it. Thanks!

[doc-rj-celltrak]

Is there a chance you can address this issue? We believe it's a one-line fix, and it will un-block us. Thanks, we appreciate your help in advance.

[doc-rj-celltrak]

To be clear, the fix is to replace this line:

persistentMutationsCallback.onResponse(new PersistentMutationsResponse(
    jsonObject.getJSONObject("data"), // ...

with this:

persistentMutationsCallback.onResponse(new PersistentMutationsResponse(
    jsonObject.optJSONObject("data"), // ...

[jamesonwilliams]

@doc-rj-celltrak thanks, looks reasonable. Our on-call engineer is having a look.

[changxu0306]

@doc-rj-celltrak Thanks for your suggestion. We've merged the fixing PR. Will do a release this week.

[doc-rj-celltrak]

Great, thanks @changxu0306 and @jamesonwilliams

[eeatonaws]

A PR with the fix for this issue was released as part of version 3.1.3.