Authentication stops working when OkHttpClient is added

[fedeperez89]

When building a AWSAppSyncClient if a OkHttpClient is provided to the builder, authentication will stop working.

Example:

val okHttpClient = OkHttpClient.Builder().addNetworkInterceptor {
    val request = it.request()
    Log.d("Request", request.toString())
    val response = it.proceed(request)
    Log.d("Response", response.toString())
    response
}.build()

client = AWSAppSyncClient.builder().context(applicationContext)
        .okHttpClient(okHttpClient)
        .apiKey(BasicAPIKeyAuthProvider("my-key"))
        .region(Regions.US_EAST_2)
        .serverUrl("my-url")
        .build()

Looking at the AWSAppSyncClient this part seems to be the issue:

AppSyncSigV4SignerInterceptor appSyncSigV4SignerInterceptor = null;

// appSyncSigV4SignerInterceptor init code excluded...

OkHttpClient okHttpClient = builder.mOkHttpClient;

if (okHttpClient == null) {
    okHttpClient = new OkHttpClient.Builder()
    .addInterceptor(appSyncSigV4SignerInterceptor)
    .build();
}

I think the authentication interceptor should also be added if okHttpClient is not null.
Is it ok if I send a PR?

[minbi]

Hi @fedeperez89 ,

You may send a pull request. The authentication interceptor should be added in both cases when null and not null. Thank you for your feedback. We will fix this in the next release.