Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Presigners that sign the querystring rather than headers #382

Closed
1 task
kggilmer opened this issue Oct 29, 2021 · 3 comments
Closed
1 task

Generate Presigners that sign the querystring rather than headers #382

kggilmer opened this issue Oct 29, 2021 · 3 comments
Labels
feature-request A feature should be added or improved. no-auto-closure We do not want this issue to be automatically closed.

Comments

@kggilmer
Copy link
Contributor

Presigned URLs are easier to work with than presigned requests, because of the extra complexity of serializing/deserializing lists of lists (headers). vs just a URL as a string.

Currently the SDK generates most presigners to use headers.

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Describe the Feature

Is your Feature Request related to a problem?

Proposed Solution

Describe alternatives you've considered

Additional Context

  • I may be able to implement this feature request
@kggilmer kggilmer added the feature-request A feature should be added or improved. label Oct 29, 2021
@kggilmer
Copy link
Contributor Author

Truth table for valid presigned operations of supported services using querystring rather than headers:

Service: S3 signedBodyValue: UNSIGNED-PAYLOAD hasBody: false location: QUERY_STRING (getobject) (GET)
Service: S3 signedBodyValue: UNSIGNED-PAYLOAD hasBody: false location: QUERY_STRING (putobject) (PUT)
Service: STS signedBodyValue: null hasBody: true location: QUERY_STRING (GET)
Service: Polly signedBodyValue: null hasBody: true location: QUERY_STRING (GET)

@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@ianbotsf
Copy link
Contributor

ianbotsf commented Dec 1, 2022

We'll handle this in smithy-kotlin#755.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Development

No branches or pull requests

3 participants