Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: implement smithy-modeled endpoint resolution for aws sdk #759

Merged
merged 13 commits into from
Nov 21, 2022
Merged

feat!: implement smithy-modeled endpoint resolution for aws sdk #759

merged 13 commits into from
Nov 21, 2022

Conversation

lucix-aws
Copy link
Contributor

@lucix-aws lucix-aws commented Nov 18, 2022 •
edited
Loading

Description of changes

  • PR to merge endpoints2 feature branch.
  • Includes changelog entries for all features that are covered by s3's endpoint ruleset.
  • Bumps project version for breaking changes.
  • Update howto for endpoint resolution.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lucix-aws lucix-aws requested a review from a team as a code owner November 18, 2022 21:23
ianbotsf
ianbotsf requested changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@ianbotsf ianbotsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing changelog entry and smithyKotlinVersion bump.

aajtodd
aajtodd approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix CI issues and ship!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 16 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@lucix-aws lucix-aws merged commit 3593e07 into main Nov 21, 2022
@lucix-aws lucix-aws deleted the feat-endpoints2 branch November 21, 2022 23:08
This was referenced Nov 22, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianbotsf ianbotsf ianbotsf approved these changes

@aajtodd aajtodd aajtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucix-aws @aajtodd @ianbotsf