core/lib/CloudFrontDistributionForApiGateway function bug

[beomseoklee]

aws-solutions-constructs/source/patterns/@aws-solutions-constructs/core/lib/cloudfront-distribution-helper.ts

Lines 119 to 125 in ccf819c

	export function CloudFrontDistributionForApiGateway(scope: cdk.Construct,
	apiEndPoint: api.RestApi,
	cloudFrontDistributionProps?: cloudfront.CloudFrontWebDistributionProps | any,
	httpSecurityHeaders?: boolean): [cloudfront.CloudFrontWebDistribution,
	lambda.Version?, s3.Bucket?] {
	const _httpSecurityHeaders = httpSecurityHeaders ? httpSecurityHeaders : true;

The above source code has a bug. No matter what parameter is provided to httpSecurityHeader, _httpSecurityHeaders would be true.

---

This is 🐛 Bug Report

[wesselvdv]

I guess the idea was to do an undefined check. This is currently messing up using this solution for a different region than us-east-1, because the edge lambda association fails.

I suggest we change it to const _httpSecurityHeaders = httpSecurityHeaders !== undefined ? httpSecurityHeaders : true; or if we need to support pre-es5 const _httpSecurityHeaders = typeof httpSecurityHeaders !== 'undefined' ? httpSecurityHeaders : true;

[hnishar]

This has been addressed in the latest release v1.54.0