feat(aws-eventbridge-kinesisfirehose-s3) created new construct #310
Conversation
…n events-rule-kinesisfirehose-s3
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| @@ -0,0 +1,85 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
This is a build product, it shouldn't have gotten checked in. Check your .gitignore
| @@ -0,0 +1,142 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
Build product, shouldn't be in git. Seems like you're miss *.js in your .gitignore file. The original .gitignore starts with:
lib/*.js
test/*.js
!test/lambda/*
*.js.map
This construct is missing the first 3 lines. The 3rd line is not needed as there is no test/lambda folder in this construct (I think), but the first 2 lines are very neccessary.
| @@ -0,0 +1,29 @@ | |||
| "use strict"; | |||
| @@ -1,6 +1,5 @@ | |||
| lib/*.js | |||
| test/*.js | |||
| !test/lambda/* | |||
There was a problem hiding this comment.
Yes, like this. Just remove this line.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #288, if available:
Description of changes:
-Created new construct for aws-eventbridge-kinesisfirehose-s3
-Created wrapper in aws-events-rule-kinesisfirehose-s3 to support new construct
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.