-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-wafwebacl-cloudfront): new construct #389
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make the shift to CloudFront from Cloudfront and if you're confident you caught them all you can go ahead and start coding.
|
||
``` typescript | ||
import { CloudFrontToS3 } from '@aws-solutions-constructs/aws-cloudfront-s3'; | ||
import { WafwebaclToCloudfront } from "@aws-solutions-constructs/aws-wafwebacl-cloudfront"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To match what's out there we should go with WafwebaclToCloudFront
|
||
// This construct can only be attached to a configured Cloudfront. | ||
new WafwebaclToCloudfront(this, 'test-wafwebacl-cloudfront', { | ||
existingCloudfrontWebDistribution: cloudfrontToS3.cloudFrontWebDistribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existingCloudFrontWebDistribution
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple very minor changes.
source/patterns/@aws-solutions-constructs/aws-wafwebacl-cloudfront/lib/index.ts
Show resolved
Hide resolved
source/patterns/@aws-solutions-constructs/aws-wafwebacl-cloudfront/lib/index.ts
Show resolved
Hide resolved
...ns/@aws-solutions-constructs/aws-wafwebacl-cloudfront/test/test.wafwebacl-cloudfront.test.ts
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #385 , if available:
Description of changes:
-created README for aws-wafwebacl-cloudfront
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes: #385