feat(aws-wafwebacl-alb): created aws-wafwebacl-alb construct #465
Conversation
mickychetta
requested review from
biffgaut,
hayesry and
hnishar
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mickychetta
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
source/patterns/@aws-solutions-constructs/aws-wafwebacl-alb/.eslintignore
Outdated
Show resolved
Hide resolved
| // Empty arguments | ||
| const stack = new Stack(app, generateIntegStackName(__filename)); | ||
|
|
||
| const r53ToAlb = new Route53ToAlb(stack, 'Route53ToAlbPattern', { |
There was a problem hiding this comment.
Rather than dragging Route53 into the mess, let's just create an ALB:
const myVpc = defaults.buildVpc(stack, {
defaultVpcProps: defaults.DefaultPublicPrivateVpcProps(),
constructVpcProps: {
enableDnsHostnames: true,
enableDnsSupport: true,
cidr: '172.168.0.0/16',
}
});
const loadBalancer = new elb.ApplicationLoadBalancer(stack, 'new-lb', {
internetFacing: false,
vpc: myVpc
});
| existingLoadBalancerObj: r53ToAlb.loadBalancer | ||
| }); | ||
|
|
||
| const newSecurityGroup = r53ToAlb.loadBalancer.connections.securityGroups[0].node.defaultChild as CfnSecurityGroup; |
There was a problem hiding this comment.
Why this? Is r53ToAlb creating code that doesn't pass cfn_nag?
There was a problem hiding this comment.
Yes, it is not passing for cdk v1
|
|
||
| expect(stack).toHaveResource("AWS::WAFv2::WebACL", { | ||
| Rules: [ | ||
| { |
There was a problem hiding this comment.
I'm hitting this on aws-alb-lambda, there's no way to ensure a subset of collection members - even if you use toHaveResourceLike (eg - we must include every rule in this list rather than just 1 or 2 as a sampling). If you ever see a way to match based on a subset of collection members I'd be very interested.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #464 , if available:
Description of changes:
-Created aws-wafwebacl-alb construct
-Created unit and integ tests for wafwebacl-alb
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
fixes #464