Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-fargate-dynamodb): create new construct #633

Merged
merged 18 commits into from
Apr 7, 2022
Merged

feat(aws-fargate-dynamodb): create new construct #633

merged 18 commits into from
Apr 7, 2022

Conversation

mickychetta
Copy link
Contributor

Issue #632 , if available:

Description of changes:
-Created README

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mickychetta mickychetta self-assigned this Mar 24, 2022
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: a345c5b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: a345c5b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut
biffgaut requested changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is to create a new construct - creating the README is just the first step. Let's title is Create New Construct rather than create README.

source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/README.md Outdated

| **Name** | **Type** | **Description** |
|:-------------|:----------------|-----------------|
| publicApi | `boolean` | Whether the construct is deploying a private or public API. This has implications for the VPC and ALB. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just list the VPC here and omit the ALB, since there is no ALB aspect to this construct (I realize the SNS, SQS and S3 constructs list the ALB, this is a change we should probably make throughout).

@mickychetta mickychetta changed the title feat(aws-fargate-dynamodb): created README for aws-fargate-dynamodb feat(aws-fargate-dynamodb): create new construct Mar 25, 2022
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: c155dbc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: c155dbc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: a53fba2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: a53fba2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: ee60453
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: ee60453
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 5e9c6d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 5e9c6d4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 4531b80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 4531b80
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut
biffgaut requested changes Apr 6, 2022
View reviewed changes
source/patterns/@aws-solutions-constructs/aws-apigateway-dynamodb/lib/index.ts Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/README.md Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/lib/index.ts Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/lib/index.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/test/fargate-dynamodb.test.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/test/fargate-dynamodb.test.ts Outdated Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/aws-fargate-dynamodb/test/fargate-dynamodb.test.ts Show resolved Hide resolved
source/patterns/@aws-solutions-constructs/core/lib/dynamodb-table-helper.ts Show resolved Hide resolved
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: e0f481e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: e0f481e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: cec5f41
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: cec5f41
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 1476e71
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 1476e71
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: 8f22294
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: 8f22294
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: ac5aed7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: ac5aed7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v2
  • Commit ID: c5085aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: githubautobuild-for-cdk-v1
  • Commit ID: c5085aa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

biffgaut
biffgaut requested changes Apr 7, 2022
View reviewed changes
source/patterns/@aws-solutions-constructs/core/lib/dynamodb-table-helper.ts
@@ -71,6 +71,30 @@ export function buildDynamoDBTable(scope: Construct, props: BuildDynamoDBTablePr
}
}

export function checkTableProps(props: BuildDynamoDBTableProps) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed part of this earlier - this ensures there isn't more than one, but it doesn't ensure there is at least one.

@biffgaut biffgaut merged commit 0b35418 into awslabs:main Apr 7, 2022
@mickychetta mickychetta linked an issue Apr 7, 2022 that may be closed by this pull request
feat(aws-fargate-dynamodb): New Construct #632
Closed
2 tasks
biffgaut added a commit that referenced this pull request Apr 9, 2022
@aws-solutions-constructs-team @biffgaut @mickychetta
chore(release): 1.150.0 (#654)
a22694b 
* feat(aws-fargate-dynamodb): create new construct (#633)

* created README for aws-fargate-dynamodb

* created aws-fargate-dynamodb construct

* revised buildDynamoDBTable helper function to support old/new constructs

* updated prop variable name

* added error and endpoint checking tests

* checked for table permissions

* checked props in input-validation

* moved table interface and object check to buildDynamoDBTable function

* created prop check function in dynamo helper file

* chore(release): 1.150.0

* chore(changelog): Updated CHANGELOG.md

* CDK version driven changes

* Align CDK version

* Sync CDk Versions

* Sync CDK versions

Co-authored-by: biffgaut <[email protected]>
Co-authored-by: mickychetta <[email protected]>
biffgaut added a commit that referenced this pull request Apr 9, 2022
@aws-solutions-constructs-team @biffgaut @mickychetta
chore(release): 1.150.0 (#654) (#655)
5cd5e60 
* feat(aws-fargate-dynamodb): create new construct (#633)

* created README for aws-fargate-dynamodb

* created aws-fargate-dynamodb construct

* revised buildDynamoDBTable helper function to support old/new constructs

* updated prop variable name

* added error and endpoint checking tests

* checked for table permissions

* checked props in input-validation

* moved table interface and object check to buildDynamoDBTable function

* created prop check function in dynamo helper file

* chore(release): 1.150.0

* chore(changelog): Updated CHANGELOG.md

* CDK version driven changes

* Align CDK version

* Sync CDk Versions

* Sync CDK versions

Co-authored-by: biffgaut <[email protected]>
Co-authored-by: mickychetta <[email protected]>

Co-authored-by: biffgaut <[email protected]>
Co-authored-by: mickychetta <[email protected]>
@biffgaut biffgaut mentioned this pull request Apr 9, 2022
Merged
biffgaut added a commit that referenced this pull request Apr 9, 2022
@biffgaut @aws-solutions-constructs-team @mickychetta
chore(release): 1.150.0 (#654) (#658)
12151b1 
* feat(aws-fargate-dynamodb): create new construct (#633)

* created README for aws-fargate-dynamodb

* created aws-fargate-dynamodb construct

* revised buildDynamoDBTable helper function to support old/new constructs

* updated prop variable name

* added error and endpoint checking tests

* checked for table permissions

* checked props in input-validation

* moved table interface and object check to buildDynamoDBTable function

* created prop check function in dynamo helper file

* chore(release): 1.150.0

* chore(changelog): Updated CHANGELOG.md

* CDK version driven changes

* Align CDK version

* Sync CDk Versions

* Sync CDK versions

Co-authored-by: biffgaut <[email protected]>
Co-authored-by: mickychetta <[email protected]>

Co-authored-by: AWS Solutions Constructs Team <[email protected]>
Co-authored-by: mickychetta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biffgaut biffgaut biffgaut approved these changes

@hnishar hnishar Awaiting requested review from hnishar

@hayesry hayesry Awaiting requested review from hayesry hayesry is a code owner

@mobri2a mobri2a Awaiting requested review from mobri2a mobri2a is a code owner

@emcfins emcfins Awaiting requested review from emcfins emcfins is a code owner

Assignees

@mickychetta mickychetta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(aws-fargate-dynamodb): New Construct
3 participants
@mickychetta @aws-solutions-constructs-team @biffgaut