fix(Test Coverage): Improve test coverage of 2 core files #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biffgaut
requested review from
hayesry,
mobri2a,
emcfins and
mickychetta
as code owners
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mickychetta
suggested changes
May 10, 2022
There was a problem hiding this comment.
Confusing behavior around deadLetterQueue prop, add more functional tests for DLQ to confirm proper creation/instantiation of queues:
// Determine whether a DLQ property should be added
if (props.deadLetterQueue) {
queueProps.deadLetterQueue = props.deadLetterQueue;
}
Comment on lines
+95
to
+97
| const returnedQueueu = defaults.buildDeadLetterQueue(stack, buildDlqProps); | ||
|
|
||
| expect(returnedQueueu).toBeUndefined(); |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mickychetta
approved these changes
May 11, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
biffgaut
added a commit
that referenced
this pull request
May 13, 2022
* chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 * chore(changelog): Updated CHANGELOG.md * chore(changelog): Updated CHANGELOG.md * Refresh to accomodate CDK changes * Align CDK V2 version * Align CDK Versions * Align CDK Versions Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]>
biffgaut
added a commit
that referenced
this pull request
May 13, 2022
* chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 * chore(changelog): Updated CHANGELOG.md * chore(changelog): Updated CHANGELOG.md * Refresh to accomodate CDK changes * Align CDK V2 version * Align CDK Versions * Align CDK Versions Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]>
biffgaut
added a commit
that referenced
this pull request
May 14, 2022
* chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 (#699) (#701) * chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 * chore(changelog): Updated CHANGELOG.md * chore(changelog): Updated CHANGELOG.md * Refresh to accomodate CDK changes * Align CDK V2 version * Align CDK Versions * Align CDK Versions Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> * Expedited update to address @types/prettier versioning issue. * chore(release): 1.156.0 * chore(changelog): Updated CHANGELOG.md Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]>
biffgaut
added a commit
that referenced
this pull request
May 14, 2022
* chore(release): 1.155.0 (#699) * chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 * chore(changelog): Updated CHANGELOG.md * chore(changelog): Updated CHANGELOG.md * Refresh to accomodate CDK changes * Align CDK V2 version * Align CDK Versions * Align CDK Versions Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> * chore(release): 1.156.0 (#704) * chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 (#699) (#701) * chore(release): 2.7.0 * chore(changelog): Updated CHANGELOG.v2.md * feat(aws-fargate-stepfunctions): new construct (#677) * created README.md * removed arn env var prop and fixed state machine doc comments * made createCloudWatchAlarms prop optional * created new construct * fixed README typo * refactored test to single concept design * updated default for vpcProps * Update copyright year to 2022 (#693) Skipping review, only copyright messages have been changed. * fix(Test Coverage): Improve test coverage of 2 core files (#691) * Added additional tests * More coverage based on review * chore(Improve documentation): Environment Variable descriptions (#692) * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update Environment Variable documenation/comments * Results of self-review * Response to review * Review 2 * Review 3 * Update DESIGN_GUIDELINES.md * Pin @types/prettier 2.6.0 til 2.6.1 issue resolved (#698) No one is available to review and this is time sensitive. The nature of the change makes any review rather perfunctory as it a single line added to the package.json file * chore(release): 1.155.0 * chore(changelog): Updated CHANGELOG.md * chore(changelog): Updated CHANGELOG.md * Refresh to accomodate CDK changes * Align CDK V2 version * Align CDK Versions * Align CDK Versions Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> * Expedited update to address @types/prettier versioning issue. * chore(release): 1.156.0 * chore(changelog): Updated CHANGELOG.md Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]> Co-authored-by: biffgaut <[email protected]> Co-authored-by: mickychetta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #690
Description of changes:
Added additional tests for both modules to improve line coverage to >90%
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.