Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pattern: aws-kinesisstreams-kinesisfirehose-s3 #74

Closed
1 task done
dscpinheiro opened this issue Sep 22, 2020 · 1 comment
Closed
1 task done

New pattern: aws-kinesisstreams-kinesisfirehose-s3 #74

dscpinheiro opened this issue Sep 22, 2020 · 1 comment
Assignees
Labels
feature-request A feature should be added or improved

Comments

@dscpinheiro
Copy link
Contributor

dscpinheiro commented Sep 22, 2020

Originally reported on #73

Kinesis Firehose supports two types (DirectPut and KinesisStreamAsSource). As of now, it isn't very straightforward to use KinesisStreamAsSource in the existing aws-kinesisfirehose-s3 pattern, since the configuration for it (https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-kinesisfirehose-deliverystream-kinesisstreamsourceconfiguration.html) requires the customer to pass the ARN of the role that provides access to the source Kinesis data stream (which is not available until after the construct is created).

Recommendation is to create a new pattern aws-kinesisstreams-kinesisfirehose-s3(internally it should still make use of aws-kinesisfirehose-s3, similar to aws-iot-kinesisfirehose-s3).

  • 👋 I may be able to implement this feature request

This is a 🚀 Feature Request

@dscpinheiro dscpinheiro added feature-request A feature should be added or improved needs-triage The issue or PR still needs to be triaged labels Sep 22, 2020
@hnishar hnishar self-assigned this Sep 23, 2020
@hnishar hnishar added in-progress This issue is being actively worked on and removed needs-triage The issue or PR still needs to be triaged labels Sep 23, 2020
@hnishar hnishar removed the in-progress This issue is being actively worked on label Oct 17, 2020
@hnishar
Copy link
Contributor

hnishar commented Oct 17, 2020

Published the pattern in the latest release v1.68.0

@hnishar hnishar closed this as completed Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved
Projects
None yet
Development

No branches or pull requests

2 participants