Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (Issue #61: aws-apigateway-iot construct update) #232

Merged
merged 3 commits into from
Jun 30, 2021
Merged

feat (Issue #61: aws-apigateway-iot construct update) #232

merged 3 commits into from
Jun 30, 2021

Conversation

surukonda
Copy link
Contributor

@surukonda surukonda commented Jun 25, 2021 •
edited
Loading

Issue 61, if available:

Description of changes: Updated the Architecture diagram and APIGateway IoT Integration Path for updating IoT thing named shadow documents

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
  • Commit ID: 1f355cf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@surukonda surukonda changed the title feat (Issue #65: aws-alb-lambda construct update) feat (Issue #61: aws-apigateway-iot construct update) Jun 25, 2021
@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
  • Commit ID: ddb7774
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut
Copy link
Contributor

A couple questions-

  • There's no discussion why make this change, what does it accomplish?
  • Were the .expected.json files generated using cdk-integ?

Thanks

@surukonda
Copy link
Contributor Author

surukonda commented Jun 29, 2021 •
edited
Loading

  • Hi @biffgaut . there are 2 different ways to update named shadows, the current implementation (in PR) is in-line with updation of classic shadow documents. From a functionality stand point there isn't any change that user of the construct would see.

  • *.expected.json files are created by cdk-integ.

@biffgaut
Copy link
Contributor

Do we have any documentation on the proposed access method? I spoke to an IoT Specialist SA who was not aware of the proposed way and pointed me to docs showing the current access method - https://docs.aws.amazon.com/iot/latest/developerguide/device-shadow-mqtt.html

biffgaut
biffgaut approved these changes Jun 30, 2021
View reviewed changes
Copy link
Contributor

@biffgaut biffgaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New URL format recommended by the service team: https://docs.aws.amazon.com/iot/latest/developerguide/device-shadow-rest-api.html

@aws-solutions-constructs-team
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
  • Commit ID: b004765
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@biffgaut biffgaut merged commit f0a05aa into awslabs:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biffgaut biffgaut biffgaut approved these changes

@hnishar hnishar Awaiting requested review from hnishar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surukonda @aws-solutions-constructs-team @biffgaut