ChatStorage:is_consecutive_message - Either the name of the function is incorrect or the check is!

[ksachdeva]

Expected Behaviour

consecutive - it means things organized sequentially

In the context of chat messages, the following is consecutive -
assistant-user-assistant-user
and the following is not consecutive
assistant-assistant or user-user

multi-agent-orchestrator/python/src/multi_agent_orchestrator/storage/chat_storage.py

Line 23 in 9abefed

return conversation[-1].role == new_message.role

The check at the above line will return true if the pattern is assistant-assistant or user-user

If someone looks at the name of the function (without considering how it is used and where it is used) they would consider the above check to be incorrect

I looked at the usage of your API in

multi-agent-orchestrator/python/src/multi_agent_orchestrator/storage/dynamodb_chat_storage.py

Line 32 in 9abefed

if self.is_consecutive_message(existing_conversation, new_message):

How it is used will not result in a functional problem/bug however the way you have named the API and used it isn't very clear and confusing.

Current Behaviour

Either the API name is incorrect or the check & usage is incorrect

Code snippet

See above

Possible Solution

• Change the check in is_consecutive function to return conversation[-1].role != new_message.role
• use the API as not is_consecutive in the ChatStorage implementation classes

Steps to Reproduce

See above