Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor measurement and printing for future features #302

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactor measurement and printing for future features #302

wants to merge 12 commits into from

Conversation

phdum-a
Copy link
Collaborator

@phdum-a phdum-a commented Nov 19, 2024

Refactoring of measurement and printing system in preparation for multi-excitation support.

  • Separates outs measurements (to be done in PostOperator only) from printing (to be done by Solvers)
  • Printing is now change from Postpro functions into small printer classes which also hold a table of results, rather than printing row-by-row. (This is where multi-excitations will add extra columns).
  • The output path is now handled using std::filesystem more consistently
  • Measurements in PostOperator are now cached so that printers don't have to worry about that the getter functions might trigger an expensive calculation or one that requires MPI communication.
  • Add PALACE_MFEM_USE_EXCEPTIONS build flag for unit tests, since catch can't test for aborts.
  • Other small tweaks and improvements

Note: The output of all solvers after these changes should be identical to the current output*, for easy testing. Changes which alter output will be in subsequent PRs.
[*With one trivial change in the logger for eigenvalues from \omega/2pi -> f]

@phdum-a phdum-a force-pushed the phdum/new_postpro branch 2 times, most recently from 910b6eb to 2e4ec3d Compare November 22, 2024 23:01
@phdum-a
Tweak build system
926fce0 
- export build commands
@phdum-a
Add flag for MFEM to throw not abort
e5e1478 
- Used for testing since Catch does not support testing aborts
@phdum-a
Simplify printing using more fmt features
5c6f27a
@phdum-a
Add small table class for csv printing
c687897 
- Add tests
- Add table wrapper for csv files for open-write-close
- Make empty cell NULL
@phdum-a
Add vdim to interpolation operator
2a9addf
@phdum-a
First pass at new postpro printers
aea3b34 
- switch post-processing functions to small classes that store data in tables
- replace sequential row printing
- separate write during sweep step and final write more clearly
@phdum-a
Clean up while loops
570ebe4
@phdum-a
Centralizes making output directory
46692f7 
- Requires non-empty output dir
- Canonicalize and sync among processors
- Introduces palace::fs namespace to stop injecting into std
@phdum-a
Change post_dir to fs::path
436afc0 
- Simplify checks since output directory always exists
@phdum-a
Rework PostOperator
98dd664 
- Cleaner separation between measurement (PostOperator) and printing (in solvers)
- Treat frequency as measurement to be supplied by solver
- Add caching system in PostOperator for all measurements, extending port case
- Simplify energy measurements using caching system
- Store pointer view to lumped/wave port operators in PostOperator where appropriate
@phdum-a
Add missing include
987c47f
@phdum-a
Fix table tests with changed default
c1a8a4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughcars hughcars Awaiting requested review from hughcars

Assignees

@hughcars hughcars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phdum-a @hughcars