fix: remove maxTime from StandardRetryStrategy

[aajtodd]

Issue #

fixes: awslabs/aws-sdk-kotlin#572

Description of changes

Removes a maximum per/operation timeout from the StandardRetryStrategy. There is no sensible default for this timeout since an operation could involve a large request stream. It also subjected operations to timeout in highly concurrent environments with lots of coroutines if the coroutine was starved and just didn't get a chance to run.

Users can still impose timeouts for any given operation with the built-in withTimeout functionality, e.g.

// timeout for the whole operation to complete (including all retries)
withTimeout(myTimeout) {
    client.fooOperation(...)
}


// timeout for a waiter to complete
withTimeout(myTimeout) {
    client.waitForFooExist(...)
}

Waiters were previously hard coded to 5 min as an absolute timeout. This appears to be arbitrary and nothing in the waiter spec dictates a maximum timeout configuration option. Waiters will still be bounded by maximum attempts (which transitively places an upper bound on time).

I also did a minor cleanup and set defaults for the StandardRetryStrategy such that we don't have to codegen the options, token bucket, and delay provider when they don't need to deviate from the default.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
10.0% Duplication