Normalize URL filenames for better reporting #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a URL is imported with the model assembler, it will now strip off leading "jar:" and "file:" prefixes in order to create a normalized de-dupe key so that imports through URLs and through Path to the same files are de-duped. This also offers better SourceLocation reporting for files that are imported through a URL.
JordonPhillips
approved these changes
Sep 11, 2020
JordonPhillips
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a URL is imported with the model assembler, it will now strip off
leading "jar:" and "file:" prefixes in order to create a normalized
de-dupe key so that imports through URLs and through Path to the same
files are de-duped. This also offers better SourceLocation reporting for
files that are imported through a URL.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.