Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eth_getProof(EIP-1186) #1522

Closed
blckngm opened this issue Nov 3, 2023 · 3 comments · Fixed by #1540
Closed

Support eth_getProof(EIP-1186) #1522

blckngm opened this issue Nov 3, 2023 · 3 comments · Fixed by #1540
Assignees

Comments

@blckngm
Copy link
Contributor

blckngm commented Nov 3, 2023

Propose-a-new-feature

IMO it would support the “right” way to implement ics-02 like light clients for axon: the light client will verify commitment path/value with the state root and the proof returned by eth_getProof.

eth_getProof is also widely supported practically (geth, parity, ganache, infura, etc.).

Alternatives you've considered

Verify commitment key/value with event/log. We'd need to emit an event when the commitment. It's more cumbersome and more likely to be vulnerable to replay attacks: a commitment can be cleared/updated and cannot be verified in new state roots, but a log can always be verified.

References

@driftluo
Copy link
Contributor

driftluo commented Nov 8, 2023

https://eips.ethereum.org/EIPS/eip-1186 Didn't say how to implement this

@blckngm
Copy link
Contributor Author

blckngm commented Nov 8, 2023

Yeah I guess we'd need to look into existing implementations (of both proof generation and verification) if we want to be compatible.

Or we can use some custom format if it's just for forcerelay.

@yangby-cryptape
Copy link
Collaborator

The status of EIP-1186 is stagnant.

ethereum/EIPs#1186 (comment) said:

API specs are now maintained at https://github.com/ethereum/execution-apis, not in the EIPs repository.
I'm going to close this issue since this repository isn't the right place for it anymore.

ethereum/EIPs#1186 (comment) said:

The EIP does not state that there should also be a field of the address which holds whatever address is being searched for. Geth returns this field in the proofs.

ethereum/EIPs#1186 (comment) said:

It would not surprise me in the slightest to find that this idea (not even an EIP, just a proposal for an idea for an EIP) is not in line with actual implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants