Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive GPG key while publishing artifacts #101

Merged
merged 5 commits into from
Jun 8, 2020

Conversation

colekettler
Copy link
Contributor

@colekettler colekettler commented Jun 5, 2020

Overview

This retrieves an up-to-date copy of the Azavea public GPG key during the run_cipublish build stage.

The CircleCI build will now retrieve the latest copy of the public key, allowing us to renew the key in the future by pushing a new signature with an extended expiration date to public keyservers.

Checklist

- [ ] New tests have been added or existing tests have been modified

  • Changelog updated

Testing Instructions

  • Verify that a valid Azavea GPG key is retrieved from a public keyserver and verified during run_cipublish.

Connects azavea/operations#446

@colekettler colekettler self-assigned this Jun 5, 2020
@colekettler colekettler marked this pull request as ready for review June 5, 2020 20:36
Comment on lines -26 to -27
gpg --batch \
--passphrase "${GPG_PASSPHRASE}" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're not using passphrase for this key, the --batch and --passphrase options are unnecessary.

@@ -22,10 +22,10 @@ aliases:
- run:
name: "Import signing key"
command: |
gpg --keyserver keyserver.ubuntu.com \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're specifying the Ubuntu keyserver here to mirror the approach taken by @jodersky. We've found that this keyserver was updated more quickly than the default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry for the needless ping Jakob, I'm way too used to at-mentioning all over the place, thanks for the inspiration!)

@@ -22,10 +22,10 @@ aliases:
- run:
name: "Import signing key"
command: |
gpg --keyserver keyserver.ubuntu.com \
--recv-keys 0x713F9F29598CFFF3 && \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the Azavea public GPG key.

@colekettler colekettler requested a review from rbreslow June 5, 2020 20:39
Copy link
Contributor

@rbreslow rbreslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colekettler colekettler merged commit 9f6cf67 into master Jun 8, 2020
@colekettler colekettler deleted the feature/cek/receive-gpg-key branch June 8, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants