Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test bbox laws #266

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Conversation

jisantuc
Copy link
Contributor

@jisantuc jisantuc commented Mar 17, 2021

Overview

I'm calling these tests "bbox laws." I added these to deal with some downstream test failures that I wasn't expecting in azavea/franklin#623. It turns out the bbox union isn't the problem, but it's still useful to include these tests

Checklist

  • New tests have been added or existing tests have been modified
  • Changelog updated (please use chan)

@jisantuc
Copy link
Contributor Author

I ran the tests about 50 times locally and didn't replicate the flaky error from a minute ago 🤔

@jisantuc jisantuc requested a review from pomadchin March 17, 2021 22:43
Copy link
Collaborator

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jisantuc jisantuc merged commit 64899be into master Mar 18, 2021
@jisantuc jisantuc deleted the bugfix/js/make-two-dim-bbox-gen-less-finicky branch March 18, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants