Update StacClient and SearchFilters JSON codecs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
changed the title
…lters circe codecs
pomadchin
force-pushed
the
feature/client-update
branch
from
f27296f to
be92b67
Compare
jisantuc
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates SearchFilters codecs (see azavea/franklin#708) as well as simplifies the StacClient interface making it 'simple'. The type memeber is removed and moved into the type parameter. Without this PR it would be hard to work with such interface and mix logging on the client side (see the POC https://github.com/geotrellis/geotrellis-server/pull/367/files)
Checklist
chan)