Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make StacClient type alias a trait #325

Merged
merged 1 commit into from
May 18, 2021
Merged

Make StacClient type alias a trait #325

merged 1 commit into from
May 18, 2021

Conversation

pomadchin
Copy link
Collaborator

@pomadchin pomadchin commented May 18, 2021 •
edited
Loading

Overview

This PR makes StacClient a trait and not a type alias, otherwise client children is really inconvenient to define:

i.e. right now it is:

class StacClientLoggingMid[F[_]] extends StacClientF[Mid[F, *], SearchFilters]

with this PR it becomes:

class StacClientLoggingMid[F[_]] extends StacClient[Mid[F, *]]

Checklist

  • Changelog updated (please use chan)

@pomadchin pomadchin changed the title Add a convenience trait instead of a type alias Add a convenience StacClient trait instead of a type alias May 18, 2021
@pomadchin pomadchin requested a review from jisantuc May 18, 2021 23:11
@pomadchin pomadchin force-pushed the feature/client-types branch from 39476f4 to 7d37122 Compare May 18, 2021 23:12
@pomadchin pomadchin force-pushed the feature/client-types branch from 7d37122 to 08027b1 Compare May 18, 2021 23:13
@pomadchin pomadchin changed the title Add a convenience StacClient trait instead of a type alias Make StacClient type alias a trait May 18, 2021
jisantuc
jisantuc approved these changes May 18, 2021
View reviewed changes
Copy link
Contributor

@jisantuc jisantuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@pomadchin pomadchin force-pushed the feature/client-types branch from 524c804 to 08027b1 Compare May 18, 2021 23:23
@pomadchin pomadchin merged commit f863ad7 into stac-utils:master May 18, 2021
@pomadchin pomadchin deleted the feature/client-types branch May 18, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisantuc jisantuc jisantuc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pomadchin @jisantuc