We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, ... very nice package.
I think I have found 3 small issues though.
react-collapse-pane/src/components/SplitPane/hooks/callbacks/useUncollapseSize.ts
Line 24 in 8fe33bd
collapsedSize
https://github.com/b-zurg/react-collapse-pane/blob/master/src/components/Resizer/index.tsx#L115 when creating the flex style for prevButtonFlex and postButtonFlex the flex-basis needs a unit, otherwise browser like chrome will ignore the applied style.
flex
prevButtonFlex
postButtonFlex
flex-basis
The examples in https://github.com/b-zurg/react-collapse-pane/blob/master/docs/README.md pass collapseOptions as property to SplitPane, but I think the prop should be named collapse.
collapseOptions
SplitPane
collapse
cheers
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Hi, ... very nice package.
I think I have found 3 small issues though.
react-collapse-pane/src/components/SplitPane/hooks/callbacks/useUncollapseSize.ts
Line 24 in 8fe33bd
this line adjust the offset by 50 pixels (hardcoded), but I think it should use
collapsedSize
for bothhttps://github.com/b-zurg/react-collapse-pane/blob/master/src/components/Resizer/index.tsx#L115
when creating the
flex
style forprevButtonFlex
andpostButtonFlex
theflex-basis
needs a unit, otherwise browser like chrome will ignore the applied style.The examples in https://github.com/b-zurg/react-collapse-pane/blob/master/docs/README.md pass
collapseOptions
as property toSplitPane
, but I think the prop should be namedcollapse
.cheers
The text was updated successfully, but these errors were encountered: