Merge pull request #1202 from bUnit-dev/release/v1.23

Release of new minor version v1.23

.config/dotnet-tools.json

@@ -9,7 +9,7 @@
       ]
     },
     "docfx": {
-      "version": "2.67.0",
+      "version": "2.70.0",
       "commands": [
         "docfx"
       ]

.github/workflows/docs-deploy.yml

@@ -23,7 +23,7 @@ jobs:
     steps:
 
       - name: 🛒 Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           token: ${{ secrets.BUNIT_BOT_TOKEN }}
@@ -68,6 +68,7 @@ jobs:
             5.0.x
             6.0.x
             7.0.x
+            8.0.x
 
       - name: 🎨 Setup color
         run: |

.github/workflows/prepare-release.yml

@@ -16,7 +16,7 @@ jobs:
     if: github.ref == 'refs/heads/main' && contains(fromJson('["major","minor"]'), github.event.inputs.versionIncrement)
     steps:   
       - name: 🛒 Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           token: ${{ secrets.BUNIT_BOT_TOKEN }}

.github/workflows/release-preview.yml

@@ -12,7 +12,7 @@ on:
       nugetRelease:
         description: 'Release to NuGet? Set to "true" to release to NuGet.org as well as GPR.'
         required: true
-        default: 'false'
+        default: 'true'
 
 jobs:
   release-preview:
@@ -21,7 +21,7 @@ jobs:
     steps:
 
       - name: 🛒 Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -36,6 +36,7 @@ jobs:
             5.0.x
             6.0.x
             7.0.x
+            8.0.x
 
       - name: 🎨 Setup color
         run: |

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
     steps:
 
       - name: 🛒 Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
           token: ${{ secrets.BUNIT_BOT_TOKEN }}
@@ -67,6 +67,7 @@ jobs:
             5.0.x
             6.0.x
             7.0.x
+            8.0.x
 
       - name: 🛠️ Update changelog
         uses: thomaseizinger/[email protected]

.github/workflows/verification.yml

@@ -36,7 +36,7 @@ jobs:
 
     steps:
       - name: 🛒 Checkout repository
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
 
@@ -48,6 +48,7 @@ jobs:
             5.0.x
             6.0.x
             7.0.x
+            8.0.x
 
       - name: 🎨 Setup color
         if: matrix.os != 'windows-latest'

CHANGELOG.md

@@ -6,6 +6,19 @@ All notable changes to **bUnit** will be documented in this file. The project ad
 
 ## [Unreleased]
 
+### Fixed
+
+- If the renderer was not idle when calling `SetParametersAndRender`, the method could return before the parameters were set and the component under test had finished rendering. This was a regression that happened in v1.21.9. Reported by [@Skintkingle](https://github.com/Skintkingle]) in <https://github.com/bUnit-dev/bUnit/issues/1188>. Fixed by [@egil](https://github.com/egil).
+
+### Added
+
+- `net8.0` support
+- Increased timeout of `WaitForAssertion` to infinite when a debugger is attached. By [@linkdotnet](https://github.com/linkdotnet).
+
+### Fixed
+
+- AngleSharp IElement extension methods do not work with `IRenderedFragment.Find`. Reported by [a2er](https://github.com/a2er). Fixed by [@linkdotnet](https://github.com/linkdotnet).
+
 ## [1.22.19] - 2023-07-28
 
 ### Added

Directory.Build.props

@@ -6,6 +6,7 @@
 		<DotNet5Version>5.0.0</DotNet5Version>
 		<DotNet6Version>6.0.0</DotNet6Version>
 		<DotNet7Version>7.0.0</DotNet7Version>
+		<DotNet8Version>8.0.0-*</DotNet8Version>
 	</PropertyGroup>
 
 	<!-- Solution wide properties -->
@@ -21,7 +22,7 @@
 		<LangVersion>11.0</LangVersion>
 		<AccelerateBuildsInVisualStudio>false</AccelerateBuildsInVisualStudio>
 		<ImplicitUsings>enable</ImplicitUsings>
-		<NoWarn>CA1014,NU5104,NETSDK1138</NoWarn>
+		<NoWarn>CA1014,NU5104,NETSDK1138,SYSLIB0051</NoWarn>
 		<CheckEolTargetFramework>false</CheckEolTargetFramework>
 
 		<!-- Used by code coverage -->
@@ -38,7 +39,7 @@
 	<PropertyGroup Label="Analyzer settings">
 		<AnalysisMode>AllEnabledByDefault</AnalysisMode>
 		<EnableNETAnalyzers>true</EnableNETAnalyzers>
-		<AnalysisLevel>latest</AnalysisLevel>
+		<AnalysisLevel>7</AnalysisLevel>
 		<EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
 	</PropertyGroup>
 
@@ -50,7 +51,7 @@
 	<!-- Shared code analyzers used for all projects in the solution -->
 	<ItemGroup Label="Code Analyzers">
 		<PackageReference Include="AsyncFixer" Version="1.6.0" PrivateAssets="All" />
-		<PackageReference Include="SonarAnalyzer.CSharp" Version="9.6.0.74858" PrivateAssets="All" />
+		<PackageReference Include="SonarAnalyzer.CSharp" Version="9.9.0.77355" PrivateAssets="All" />
 	</ItemGroup>
 
 	<ItemGroup Label="Implicit usings"

benchmark/bunit.benchmarks/bunit.benchmarks.csproj

@@ -8,7 +8,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="BenchmarkDotNet" Version="0.13.5" />
+      <PackageReference Include="BenchmarkDotNet" Version="0.13.7" />
     </ItemGroup>
 
     <ItemGroup>

docs/site/docs/interaction/awaiting-async-state.md

@@ -47,3 +47,7 @@ The timeout, which defaults to one second, can be controlled by passing a `TimeS
 If the timeout is reached, a <xref:Bunit.Extensions.WaitForHelpers.WaitForFailedException> exception is thrown with the following error message:
 
 > The state predicate did not pass before the timeout period passed.
+
+## Debugging code that uses `WaitForState`, `WaitForAssertion`, or `WaitForElement`
+
+When `bUnit` detects that a debugger is attached (`Debugger.IsAttached`), it will automatically disable the timeout functionality of the "wait for" methods.

global.json

@@ -1,6 +1,6 @@
 {
 	"sdk": {
 		"rollForward": "latestMajor",
-		"allowPrerelease": false
+		"allowPrerelease": true
 	}
 }

src/bunit.core/Extensions/RenderedComponentRenderExtensions.cs

@@ -30,7 +30,15 @@ public static void SetParametersAndRender<TComponent>(this IRenderedComponentBas
 			throw new ArgumentNullException(nameof(renderedComponent));
 
 		var renderer = renderedComponent.Services.GetRequiredService<TestRenderer>();
-		renderer.SetDirectParameters(renderedComponent, parameters);
+
+		try
+		{
+			renderer.SetDirectParametersAsync(renderedComponent, parameters).GetAwaiter().GetResult();
+		}
+		catch (AggregateException e) when (e.InnerExceptions.Count == 1)
+		{
+			ExceptionDispatchInfo.Capture(e.InnerExceptions[0]).Throw();
+		}
 	}
 
 	/// <summary>

src/bunit.core/Extensions/WaitForHelpers/RenderedFragmentWaitForHelperExtensions.cs

@@ -20,6 +20,9 @@ public static class RenderedFragmentWaitForHelperExtensions
 	/// <param name="statePredicate">The predicate to invoke after each render, which must returns <c>true</c> when the desired state has been reached.</param>
 	/// <param name="timeout">The maximum time to wait for the desired state.</param>
 	/// <exception cref="WaitForFailedException">Thrown if the <paramref name="statePredicate"/> throw an exception during invocation, or if the timeout has been reached. See the inner exception for details.</exception>
+	/// <remarks>
+	/// If a debugger is attached the timeout is set to <see cref="Timeout.InfiniteTimeSpan" />, giving the possibility to debug without the timeout triggering.
+	/// </remarks>
 	public static void WaitForState(this IRenderedFragmentBase renderedFragment, Func<bool> statePredicate, TimeSpan? timeout = null)
 	{
 		using var waiter = new WaitForStateHelper(renderedFragment, statePredicate, timeout);

src/bunit.core/Extensions/WaitForHelpers/WaitForAssertionHelper.cs

@@ -23,6 +23,9 @@ public class WaitForAssertionHelper : WaitForHelper<object?>
 	/// <param name="renderedFragment">The rendered fragment to wait for renders from and assert against.</param>
 	/// <param name="assertion">The verification or assertion to perform.</param>
 	/// <param name="timeout">The maximum time to attempt the verification.</param>
+	/// <remarks>
+	/// If a debugger is attached the timeout is set to <see cref="Timeout.InfiniteTimeSpan" />, giving the possibility to debug without the timeout triggering.
+	/// </remarks>
 	public WaitForAssertionHelper(IRenderedFragmentBase renderedFragment, Action assertion, TimeSpan? timeout = null)
 		: base(
 			  renderedFragment,

src/bunit.core/Extensions/WaitForHelpers/WaitForHelper.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using Bunit.Rendering;
 using Microsoft.Extensions.Logging;
 
@@ -194,6 +195,8 @@ private void SubscribeToOnAfterRender()
 
 	private static TimeSpan GetRuntimeTimeout(TimeSpan? timeout)
 	{
-		return timeout ?? TestContextBase.DefaultWaitTimeout;
+		return Debugger.IsAttached
+			? Timeout.InfiniteTimeSpan
+			: timeout ?? TestContextBase.DefaultWaitTimeout;
 	}
 }