Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Incorrect estraverse require #680

Closed
arcanis opened this issue Sep 2, 2018 · 1 comment
Closed

Incorrect estraverse require #680

arcanis opened this issue Sep 2, 2018 · 1 comment

Comments

@arcanis
Copy link

arcanis commented Sep 2, 2018

babel-eslint is requiring estraverse using eslintMod - this is invalid, since estraverse is not listed as a dependency of eslint. Should it be added as dependency of babel-eslint, and a real require be used instead?

var estraverse = eslintMod.require("estraverse");

@arcanis
Copy link
Author

arcanis commented Sep 22, 2018

Ping @hzoo @loganfsmyth? 🙂

@hzoo hzoo closed this as completed in c333bd6 Sep 25, 2018
nicolo-ribaudo pushed a commit to babel/babel that referenced this issue Nov 14, 2019
An alternative to adding a direct dep on estraverse (babel/babel-eslint#685), let's just drop the old monkeypatching behavior.

Closes babel/babel-eslint#685, Closes babel/babel-eslint#680
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@arcanis and others