This repository has been archived by the owner on Aug 18, 2021. It is now read-only.
➕ Added estraverse dependency
#685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This would also help with Plug'n'Play! 🙂 |
|
Ok looks like it was removed in eslint/eslint#8755 so they don't actually use the module at all now. Was a while ago, are we able to just use the ESlint traverser then @mysticatea? |
|
How about releasing a major version that drops support for patching scope? |
|
Yeah let's just do that instead |
|
Sounds like we should do something like #689 + peerDep eslint 5 + major version? |
kaicataldo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
An alternative to adding a direct dep on estraverse (babel/babel-eslint#685), let's just drop the old monkeypatching behavior. Closes #685, Closes #680
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
An alternative to adding a direct dep on estraverse (babel/babel-eslint#685), let's just drop the old monkeypatching behavior. Closes babel/babel-eslint#685, Closes babel/babel-eslint#680
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I propose this PR in order to solve a problem related to
estraversedependency which is used in./lib/patch-eslint-scope.js. Currentlybabel-eslintimport this dependency from eslintMod (allows to import the module ofeslint) except this is a problem becauseestraverseisn't a dependency used byeslint. This produce an error when we use the package managerpnpmfor example.To solve this problem, we install
estraversein the dependencies and modify "patch-eslint-scope.js" to use it.Current issue opened : Incorrect estraverse require #680