This repository has been archived by the owner on May 19, 2018. It is now read-only.
Implement nullish coalescing operator in parser #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the tests, I would check https://github.com/babel/babylon/pull/742/files which is similar Could do chained so |
existentialism
approved these changes
Oct 14, 2017
There was a problem hiding this comment.
👍 fine with plugin name, and agreed on adding the tests @hzoo mentioned
|
cc @littledan |
|
Fine with merging now if we can get a PR for tests next, (logic shouldn't be any different) |
|
new PR #762, should probably be |
2 tasks
jridgewell
reviewed
Oct 15, 2017
| @@ -791,6 +791,7 @@ enum BinaryOperator { | |||
| | "|" | "^" | "&" | "in" | |||
| | "instanceof" | |||
| | "|>" | |||
| | "??" | |||
There was a problem hiding this comment.
This is a LogicalOperator, not a BinaryOperator
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the parser for the nullish coalescing operator,
a ?? b, currently at stage 1.In the AST it isn an operator under
BinaryExpression. Should it move toLogicalExpression?Picked the plugin name:
"nullishCoalescingOperator". It's a bit of a mouthful, and may well change.Ref: babel/proposals#14
Proposal: https://github.com/gisenberg/proposal-null-coalescing
Proposal will likely be renamed from
nullarytonullish, see tc39/proposal-nullish-coalescing#3.I feel like I haven't added enough tests, but I'm not too sure of the edge cases I should test, let me know if you know of any!