Blacklists @ember/string if dependency is present
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
locks
commented
Aug 11, 2017
•
locks
commented
- Add behaviour
- Test behaviour
|
@locks what the test? use case I want help you on this |
|
@locks - Looks good, I just released the polyfill with the required changes, can you rebase and update the minimum version? |
|
@villander we need to check that we are actually detecting |
locks
changed the title
@ember/string if dependency is present
rwjblue
reviewed
Aug 29, 2017
index.js
Outdated
| @@ -253,14 +253,19 @@ module.exports = { | |||
| }, | |||
|
|
|||
| _getEmberModulesAPIPolyfill(config) { | |||
| const blacklist = { '@ember/debug': ['assert', 'deprecate', 'warn'] }; | |||
There was a problem hiding this comment.
Can you extract the logic here into a _getEmberModulesAPIBlacklist() method?
There was a problem hiding this comment.
Addressed, was that what you had in mind?
|
We are G.T.G.™ |
This was referenced Sep 1, 2017
Turbo87
reviewed
Nov 8, 2017
index.js
Outdated
| _emberStringDependencyPresent() { | ||
| let checker = new VersionChecker(this.parent).for('@ember/string', 'npm'); | ||
|
|
||
| return checker.isAbove('0.0.0'); |
There was a problem hiding this comment.
why .isAbove()? I think there is an .exists() now 🤔
There was a problem hiding this comment.
Ya, confirm. But only recently IIRC.
If the `@ember/string` package is present in the dependencies it means that we should not convert the imports for those modules into globals, because the modules will be provided by the package itself.
rwjblue
approved these changes
Nov 8, 2017
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.